Skip to content

Update require_pulp_plugins#332

Merged
dralley merged 2 commits intopulp:masterfrom
fao89:require_pulp_plugins
Mar 11, 2021
Merged

Update require_pulp_plugins#332
dralley merged 2 commits intopulp:masterfrom
fao89:require_pulp_plugins

Conversation

@fao89
Copy link
Copy Markdown
Member

@fao89 fao89 commented Mar 4, 2021

[noissue]

@fao89
Copy link
Copy Markdown
Member Author

fao89 commented Mar 4, 2021

@pulp/python the test were being skipped, it enables the tests again, but I don't have the background for fixing these tests

@fao89 fao89 force-pushed the require_pulp_plugins branch 2 times, most recently from c07f1b8 to cfcb360 Compare March 11, 2021 12:44
@fao89
Copy link
Copy Markdown
Member Author

fao89 commented Mar 11, 2021

I rebased my PR, so I got this change:
https://github.com/pulp/pulp_python/pull/334/files
which uses http://pulp-fixtures:8080/
https://github.com/pulp/pulp_python/blob/master/.ci/ansible/smash-config.json#L34
but now the error is due https

pulp_smash.pulp3.bindings.PulpTaskError: (PulpTaskError(...), 'Pulp task failed (Master URL http://pulp-fixtures:8080/python-pypi/ is not https scheme)')

what is the right fixture?

@gerrod3
Copy link
Copy Markdown
Contributor

gerrod3 commented Mar 11, 2021

what is the right fixture?

Bandersnatch requires the remote url to be https, so the fixtures url must point to our hosted fixtures and not use the container built fixtures.

@fao89
Copy link
Copy Markdown
Member Author

fao89 commented Mar 11, 2021

what is the right fixture?

Bandersnatch requires the remote url to be https, so the fixtures url must point to our hosted fixtures and not use the container built fixtures.

if we set docker-fixture: false we will get https://fixtures.pulpproject.org but it may break CLI test:
pulp/plugin_template@24fbd58
when you enable it:
https://github.com/pulp/pulp_python/blob/master/template_config.yml#L37

@gerrod3
Copy link
Copy Markdown
Contributor

gerrod3 commented Mar 11, 2021

Hmm, where is that variable docker_fixtures being set? We should turn that off so that it chooses the hosted fixtures instead.

@fao89 fao89 force-pushed the require_pulp_plugins branch from cfcb360 to d2efc04 Compare March 11, 2021 16:22
Comment thread template_config.yml
deploy_daily_client_to_rubygems: true
deploy_to_pypi: true
docker_fixtures: true
docker_fixtures: false
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I turned it off and ran plugin-template

@fao89
Copy link
Copy Markdown
Member Author

fao89 commented Mar 11, 2021

Finally green \o/
@pulp/python

@dralley dralley merged commit 468d553 into pulp:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants